Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not queue installations on vanilla osquery devices #21718

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

lucasmrod
Copy link
Member

Another small fix for #21428.

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 52.98%. Comparing base (3cabefc) to head (3ccff2e).
Report is 29 commits behind head on main.

Files with missing lines Patch % Lines
server/service/osquery.go 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main   #21718       +/-   ##
===========================================
+ Coverage   39.50%   52.98%   +13.48%     
===========================================
  Files        1483     1498       +15     
  Lines      139518   142799     +3281     
  Branches     3498     3488       -10     
===========================================
+ Hits        55117    75664    +20547     
+ Misses      79241    61098    -18143     
- Partials     5160     6037      +877     
Flag Coverage Δ
backend 52.93% <80.00%> (+14.68%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@getvictor getvictor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucasmrod lucasmrod merged commit c6e2045 into main Aug 30, 2024
24 checks passed
@lucasmrod lucasmrod deleted the 21428-do-not-queue-on-vanilla-osquery branch August 30, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants